Changeset 1823

Timestamp:

09/10/08 15:19:07 (23 months ago)

Author:

mikey

Message:

implement enhancement #169

Location:

framework/trunk/src

Files:

• main/php/net/stubbles/xml/rss/stubRSSFeedGenerator.php (modified) (2 diffs)
• test/php/net/stubbles/xml/rss/stubRSSFeedGeneratorTestCase.php (modified) (2 diffs)

framework/trunk/src/main/php/net/stubbles/xml/rss/stubRSSFeedGenerator.php

@@ -186 +186 @@
 
     /**
+     * checks whether an item is present at given position
+     *
+     * @param   int   $pos
+     * @return  bool
+     */
+    public function hasItem($pos)
+    {
+        return isset($this->items[$pos]);
+    }
+
+    /**
+     * returns item at given position
+     *
+     * @param   int              $pos
+     * @return  stubRssFeedItem
+     */
+    public function getItem($pos)
+    {
+        if ($this->hasItem($pos) === true) {
+            return $this->items[$pos];
+        }
+        
+        return null;
+    }
+
+    /**
+     * returns a list of all items
+     *
+     * @return  stubRssFeedItem
+     */
+    public function getItems()
+    {
+        return $this->items;
+    }
+
+    /**
+     * returns the number of items added for this feed
+     *
+     * @return  int
+     */
+    public function countItems()
+    {
+        return count($this->items);
+    }
+
+    /**
      * set the generator of the feed
      *
@@ -434 +480 @@
         return $xmlStreamWriter;
     }
-
-    /**
-     * returns the number of items added for this feed
-     *
-     * @return  int
-     */
-    public function countItems()
-    {
-        return count($this->items);
-    }
 }
 ?>

framework/trunk/src/test/php/net/stubbles/xml/rss/stubRSSFeedGeneratorTestCase.php

@@ -46 +46 @@
 
     /**
+     * item handling should work correct
+     *
+     * @test
+     */
+    public function itemHandling()
+    {
+        $this->assertEquals(0, $this->rssFeedGenerator->countItems());
+        $this->assertEquals(array(), $this->rssFeedGenerator->getItems());
+        $this->assertFalse($this->rssFeedGenerator->hasItem(0));
+        $this->assertFalse($this->rssFeedGenerator->hasItem(1));
+        $this->assertNull($this->rssFeedGenerator->getItem(0));
+        $this->assertNull($this->rssFeedGenerator->getItem(1));
+        $item0 = $this->rssFeedGenerator->addItem('item0', 'link', 'description');
+        $this->assertEquals(1, $this->rssFeedGenerator->countItems());
+        $this->assertEquals(array($item0), $this->rssFeedGenerator->getItems());
+        $this->assertTrue($this->rssFeedGenerator->hasItem(0));
+        $this->assertFalse($this->rssFeedGenerator->hasItem(1));
+        $this->assertSame($item0, $this->rssFeedGenerator->getItem(0));
+        $this->assertNull($this->rssFeedGenerator->getItem(1));
+        $item1 = $this->rssFeedGenerator->addItem('item0', 'link', 'description');
+        $this->assertEquals(2, $this->rssFeedGenerator->countItems());
+        $this->assertEquals(array($item0, $item1), $this->rssFeedGenerator->getItems());
+        $this->assertTrue($this->rssFeedGenerator->hasItem(0));
+        $this->assertTrue($this->rssFeedGenerator->hasItem(1));
+        $this->assertSame($item0, $this->rssFeedGenerator->getItem(0));
+        $this->assertSame($item1, $this->rssFeedGenerator->getItem(1));
+    }
+
+    /**
      * test that the values are handles as expexted
      *
@@ -53 +82 @@
     {
         $this->assertEquals(0, $this->rssFeedGenerator->countItems());
-        
         $mockXmlStreamWriter = $this->getMock('stubXMLStreamWriter');
         $mockXmlStreamWriter->expects($this->never())->method('writeProcessingInstruction');