Ticket #150 (closed defect: fixed)

Opened 20 months ago

Last modified 20 months ago

Carriage return not detected correctly when parsing annotations

Reported by: prema Owned by: mikey
Priority: major Milestone: 0.9.0
Component: ReflectionApi Version: SVN-trunk
Keywords: Cc:

Description (last modified by mikey) (diff)

When source files are stored with carriage return (though this is discouraged) the following situation is not detected correctly by the annotation parser:

/**
 * a description
 *
 * @param   string  $id  a param
 * @return  string
 * @Id
 */
public function setId($id) {...}

Here, the id annotation is not correctly recognized in case the d is followed by a carriage return instead of a unix line break.

Change History

Changed 20 months ago by mikey

  • milestone set to 0.9.0

Changed 20 months ago by mikey

The problem seems to be windows line endings (carriage return), they are not detected correctly by the annotation name state.

Changed 20 months ago by mikey

  • status changed from new to assigned

Changed 20 months ago by mikey

  • description modified (diff)
  • summary changed from Annotation problem without using brackets to Carriage return not detected correctly when parsing annotations

Changed 20 months ago by mikey

  • status changed from assigned to closed
  • resolution set to fixed

Fixed with r1712.

Note: See TracTickets for help on using tickets.